fix(test): stabilize flaky StackTrace URL link tooltip test#111900
Closed
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Closed
fix(test): stabilize flaky StackTrace URL link tooltip test#111900JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
JoshuaKGoldberg
added
Scope: Frontend
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
changed the base branch from
fix/flaky-test-rerun-infra
to
master
Made-with: Cursor
JoshuaKGoldberg
force-pushed
the
fix/flaky-stack-trace-spec
branch
from
1f1f5cc to
9a29b51
Compare
JoshuaKGoldberg
removed
the
Frontend: Rerun Flaky Tests
Member
Author
|
I suspect this was actually fixed by #112196. Closing out for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last test in the file calls
jest.useRealTimers()before its finalexpect(await ...)assertion. Other tests in the file call that after the final assertion. It looks like tooltip transitions can still be chugging along internally when the machine is slow, so swapping timers mid-way through them cause flake.Note that CI Jest tests are failing because the Frontend: Rerun Flaky TestsKnown flaky tests should be run many times, just to be safe.
label is causing other, still-flaky tests to be run.No longer applicable now that this is targetingmasterand #111860 is not yet merged.Fixes ENG-7192
Made with Cursor